Post-merge-review: Fix template-no-aria-unsupported-elements false positives on title/base/head/link#2655
Closed
johanrd wants to merge 2 commits intoember-cli:masterfrom
Closed
Conversation
…in upstream The port included title, base, head, and link in the unsupported elements set, but the upstream ember-template-lint only has html, meta, script, and style. The extra elements caused false positives.
| 'script', | ||
| 'style', | ||
| 'title', | ||
| 'base', |
Contributor
There was a problem hiding this comment.
do these support aria? if not, they should be re-added to this list
Contributor
Author
There was a problem hiding this comment.
okay, true, good call, the original PR's motivation was alignment with ember-template-lint, but a more comprehensive list is probably better
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's broken on
masterELEMENTS_WITHOUT_ARIA_SUPPORTcontains 8 tags. Upstream has only 4:html,meta,script,style(no-aria-unsupported-elements.jsL7). Master flags valid usage of ARIA attributes on<title>,<base>,<head>, and<link>.Fix
Remove
title,base,head,linkfrom the disallowed set, matching upstream exactly.Test plan
Co-written by Claude.